lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Sep 2022 13:17:48 +0200 From: Bartosz Golaszewski <brgl@...ev.pl> To: Pali Rohár <pali@...nel.org> Cc: Linus Walleij <linus.walleij@...aro.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] gpio: mpc8xxx: Fix support for IRQ_TYPE_LEVEL_LOW flow_type in mpc85xx On Tue, Sep 6, 2022 at 12:54 PM Pali Rohár <pali@...nel.org> wrote: > > Commit e39d5ef67804 ("powerpc/5xxx: extend mpc8xxx_gpio driver to support > mpc512x gpios") implemented support for IRQ_TYPE_LEVEL_LOW flow type in > mpc512x via falling edge type. Do same for mpc85xx which support was added > in commit 345e5c8a1cc3 ("powerpc: Add interrupt support to mpc8xxx_gpio"). > > Fixes probing of lm90 hwmon driver on mpc85xx based board which use level > interrupt. Without it kernel prints error and refuse lm90 to work: > > [ 15.258370] genirq: Setting trigger mode 8 for irq 49 failed (mpc8xxx_irq_set_type+0x0/0xf8) > [ 15.267168] lm90 0-004c: cannot request IRQ 49 > [ 15.272708] lm90: probe of 0-004c failed with error -22 > > Fixes: 345e5c8a1cc3 ("powerpc: Add interrupt support to mpc8xxx_gpio") > Signed-off-by: Pali Rohár <pali@...nel.org> > --- > drivers/gpio/gpio-mpc8xxx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c > index a964e25ea620..763256efddc2 100644 > --- a/drivers/gpio/gpio-mpc8xxx.c > +++ b/drivers/gpio/gpio-mpc8xxx.c > @@ -172,6 +172,7 @@ static int mpc8xxx_irq_set_type(struct irq_data *d, unsigned int flow_type) > > switch (flow_type) { > case IRQ_TYPE_EDGE_FALLING: > + case IRQ_TYPE_LEVEL_LOW: > raw_spin_lock_irqsave(&mpc8xxx_gc->lock, flags); > gc->write_reg(mpc8xxx_gc->regs + GPIO_ICR, > gc->read_reg(mpc8xxx_gc->regs + GPIO_ICR) > -- > 2.20.1 > Applied, thanks! Bart
Powered by blists - more mailing lists