lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Sep 2022 19:19:58 +0800 From: Abel Wu <wuyun.abel@...edance.com> To: Peter Zijlstra <peterz@...radead.org>, Mel Gorman <mgorman@...e.de>, Vincent Guittot <vincent.guittot@...aro.org> Cc: Josh Don <joshdon@...gle.com>, Chen Yu <yu.c.chen@...el.com>, Yicong Yang <yangyicong@...wei.com>, linux-kernel@...r.kernel.org, Abel Wu <wuyun.abel@...edance.com>, Mel Gorman <mgorman@...hsingularity.net> Subject: [PATCH v4 3/5] sched/fair: Remove useless check in select_idle_core() The function select_idle_core() only gets called when has_idle_cores is true which can be possible only when sched_smt_present is enabled. This change also aligns select_idle_core() with select_idle_smt() in the way that the caller do the check if necessary. Signed-off-by: Abel Wu <wuyun.abel@...edance.com> Acked-by: Mel Gorman <mgorman@...hsingularity.net> --- kernel/sched/fair.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1ad79aaaaf93..03ce65068333 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6321,9 +6321,6 @@ static int select_idle_core(struct task_struct *p, int core, struct cpumask *cpu bool idle = true; int cpu; - if (!static_branch_likely(&sched_smt_present)) - return __select_idle_cpu(core, p); - for_each_cpu(cpu, cpu_smt_mask(core)) { if (!available_idle_cpu(cpu)) { idle = false; -- 2.37.3
Powered by blists - more mailing lists