[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <783df4f0-0b7e-8604-d61f-f78e0375c321@linaro.org>
Date: Wed, 7 Sep 2022 13:25:48 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Smitha T Murthy <smitha.t@...sung.com>,
linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc: m.szyprowski@...sung.com, andrzej.hajda@...el.com,
mchehab@...nel.org, hverkuil-cisco@...all.nl,
ezequiel@...guardiasur.com.ar, jernej.skrabec@...il.com,
benjamin.gaignard@...labora.com, stanimir.varbanov@...aro.org,
dillon.minfei@...il.com, david.plowman@...pberrypi.com,
mark.rutland@....com, robh+dt@...nel.org, krzk+dt@...nel.org,
andi@...zian.org, alim.akhtar@...sung.com,
aswani.reddy@...sung.com, pankaj.dubey@...sung.com,
linux-fsd@...la.com, aakarsh.jain@...sung.com
Subject: Re: [Patch v2 15/15] arm64: dts: fsd: Add MFC related DT enteries
On 07/09/2022 08:47, Smitha T Murthy wrote:
> Add MFC DT node and reserve memory node for MFC usage.
>
> Cc: linux-fsd@...la.com
> Signed-off-by: Smitha T Murthy <smitha.t@...sung.com>
> ---
> arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++++
> arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++++++++++++++++++++++
> 2 files changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> index 1db6ddf03f01..17bb048f9d47 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> @@ -30,6 +30,10 @@
> };
> };
>
> +&clock_mfc {
> + status = "okay";
clock node was never disabled, so there is no need to enable it.
> +};
> +
> &fin_pll {
> clock-frequency = <24000000>;
> };
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index f35bc5a288c2..bca0ba030ee7 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -340,6 +340,18 @@
> #clock-cells = <0>;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + mfc_left: region@...00000 {
> + compatible = "shared-dma-pool";
> + no-map;
> + reg = <0 0x84000000 0 0x8000000>;
> + };
> + };
> +
> soc: soc@0 {
> compatible = "simple-bus";
> #address-cells = <2>;
> @@ -832,6 +844,16 @@
> clock-names = "fin_pll", "mct";
> };
>
> + mfc: mfc@...80000 {
> + compatible = "samsung,fsd-mfc";
> + reg = <0x0 0x12880000 0x0 0x10000>;
> + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "mfc";
> + clocks = <&clock_mfc MFC_MFC_IPCLKPORT_ACLK>;
> + memory-region = <&mfc_left>;
> + status = "okay";
Okay is by default, don't add it.
> + };
> +
> ufs: ufs@...20000 {
> compatible = "tesla,fsd-ufs";
> reg = <0x0 0x15120000 0x0 0x200>, /* 0: HCI standard */
Best regards,
Krzysztof
Powered by blists - more mailing lists