[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YxiMOO+8Zz5bnUQ3@8bytes.org>
Date: Wed, 7 Sep 2022 14:19:04 +0200
From: Joerg Roedel <joro@...tes.org>
To: Robin Murphy <robin.murphy@....com>
Cc: will@...nel.org, iommu@...ts.linux.dev, subkhankulov@...ras.ru,
khoroshilov@...ras.ru, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/io-pgtable-arm: Remove iommu_dev==NULL special case
On Mon, Aug 15, 2022 at 05:15:55PM +0100, Robin Murphy wrote:
> The special case to allow iommu_dev==NULL in __arm_lpae_alloc_pages() is
> confusing to static checkers (and possibly readers in general), since
> it's not obvious that that is only intended for the selftests. However
> it only serves to get around the dev_to_node() call, and we can easily
> fake up enough to make that work anyway, so let's simply remove this
> consideration from the normal flow and punt the responsibility over to
> the test harness itself.
>
> Reported-by: Rustam Subkhankulov <subkhankulov@...ras.ru>
> Signed-off-by: Robin Murphy <robin.murphy@....com>
Applied, thanks.
Powered by blists - more mailing lists