linux-kernel - RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR11MB366846DC380A755B64E870ADE9419@BN8PR11MB3668.namprd11.prod.outlook.com>
Date:   Wed, 7 Sep 2022 12:40:11 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <arnd@...db.de>, <sudipm.mukherjee@...il.com>,
        <gregkh@...uxfoundation.org>
CC:     <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-next@...r.kernel.org>
Subject: RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
 microchip: pci1xxxx: Add power management functions - suspend & resume
 handlers.")

> -----Original Message-----
> From: Arnd Bergmann <arnd@...db.de>
> Sent: Wednesday, September 7, 2022 2:12 PM
> To: Sudip Mukherjee <sudipm.mukherjee@...il.com>; Greg Kroah-
> Hartman <gregkh@...uxfoundation.org>
> Cc: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>; open list:GPIO SUBSYSTEM
> <linux-gpio@...r.kernel.org>; linux-kernel <linux-kernel@...r.kernel.org>;
> linux-next <linux-next@...r.kernel.org>
> Subject: Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip: pci1xxxx: Add power management functions - suspend & resume
> handlers.")
> 
> 
> On Tue, Sep 6, 2022, at 11:07 PM, Sudip Mukherjee wrote:
> > On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >> On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink)
> wrote:
> >> >
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> >> >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
> >> >       |            ^~~~~~~~~~~~~~~~~~~~
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> >> >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> >> >       |            ^~~~~~~~~~~~~~~~~~~~~
> >> >
> >> >
> >> > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add
> power management functions - suspend & resume handlers.").
> >> >
> >
> > Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
> > pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
> > "#ifdef CONFIG_PM_SLEEP".
Thank you Sudip ! I will review this.
> 
> That would work, but a better fix is to use DEFINE_SIMPLE_DEV_PM_OPS()
> in place of the deprecated SIMPLE_DEV_PM_OPS().
Thank you Arnd ! I will review this.