linux-kernel - Re: [PATCH v2] MIPS: octeon: Get rid of preprocessor directives around RESERVE32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2022 15:02:20 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Alexander A Sverdlin <alexander.sverdlin@...ia.com>
Cc:     Yu Zhao <yuzhao@...gle.com>, Joe Perches <joe@...ches.com>,
        linux-mips@...r.kernel.org, Corey Minyard <cminyard@...sta.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] MIPS: octeon: Get rid of preprocessor directives
 around RESERVE32

On Tue, Sep 06, 2022 at 10:32:39AM +0200, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> 
> Some of them were pointless because CONFIG_CAVIUM_RESERVE32 is now always
> defined, some were not enough (Yu Zhao reported
> "Failed to allocate CAVIUM_RESERVE32 memory area" error).
> 
> Removing the directives allows for compiler coverage of RESERVE32 code and
> replacing one of [always-true] "ifdef" with a compiler conditional fixes
> the [cosmetic] error message.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> ---
> 
> Changelog:
> v2:
> * Reduced the scope of addr variable
> 
>  arch/mips/cavium-octeon/executive/cvmx-cmd-queue.c |  4 ----
>  arch/mips/cavium-octeon/setup.c                    | 27 +++++++++-------------

applied to mips-fixes with

Fixes: 3e3114ac460e ("MIPS: Introduce CAVIUM_RESERVE32 Kconfig option")

added.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]