linux-kernel - Re: linux-next: build failure after merge of the kbuild tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2022 22:49:23 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the kbuild tree

On Wed, Sep 7, 2022 at 9:35 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> /home/sfr/next/next/scripts/mkuboot.sh: line 23: 153700 Bus error               ${MKIMAGE} "$@"
>
> Caused by commit
>
>   c4a7f46f7105 ("kbuild: build init/built-in.a just once")
>
> Reverting that commit (and the following ones) fixes the problem. It
> looks like UIMAGE_NAME gets corrupted in scripts/Makefile.lib as the
> arguments to mkuboot.sh change from
>
> A ppc -O linux -T kernel -C gzip -a 0x00700000 -e 0x007015a4 -n Linux-6.0.0-rc4 -d arch/powerpc/boot/cuImage.sam440ep.gz arch/powerpc/boot/cuImage.sam440ep
>
> to
>
> -A ppc -O linux -T kernel -C gzip -a 0x00700000 -e 0x007015a4 -n Linux-6.0.0-rc4 6.0.0-rc4 -d arch/powerpc/boot/cuImage.sam440ep.gz arch/powerpc/boot/cuImage.sam440ep
>
> (note the extra "6.0.0-rc4") when the above commit is present.
>
> So I have reverted commit c4a7f46f7105 and all the following commits in
> the kbuild tree for today.
>
> I had to do the above build with -j40 to make it consistently fail.
>
> --
> Cheers,
> Stephen Rothwell


Thanks.
arch/powerpc/boot/wrapper searches for the version string in vmlinux,
but now it gets two lines.

I will fix up as follows:


diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index 55978f32fa77..5bdd4dd20bbb 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -433,7 +433,7 @@ fi
 # Extract kernel version information, some platforms want to include
 # it in the image header
 version=`${CROSS}strings "$kernel" | grep '^Linux version [-0-9.]' | \
-    cut -d' ' -f3`
+    head -n1 | cut -d' ' -f3`
 if [ -n "$version" ]; then
     uboot_version="-n Linux-$version"
 fi


-- 
Best Regards
Masahiro Yamada