[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220907145808.1789249-1-weiyongjun@huaweicloud.com>
Date: Wed, 7 Sep 2022 14:58:04 +0000
From: Wei Yongjun <weiyongjun@...weicloud.com>
To: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Wei Yongjun <weiyongjun1@...wei.com>, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH -next v2 1/5] misc: microchip: pci1xxxx: fix error handling in gp_aux_bus_probe()
From: Wei Yongjun <weiyongjun1@...wei.com>
In some error handling path, resoures alloced may not released.
This patch fix them.
Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.")
Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
---
v1 - > v2: add fixes tag, fix pci_alloc_irq_vectors handing
---
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
index bfc03028b34d..11f79f239006 100644
--- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
+++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
@@ -87,12 +87,13 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id
retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
if (retval < 0)
- return retval;
+ goto err_aux_dev_init_1;
- pdev->irq = pci_irq_vector(pdev, 0);
- if (pdev->irq < 0)
- return retval;
+ retval = pci_irq_vector(pdev, 0);
+ if (retval < 0)
+ goto err_aux_dev_init_1;
+ pdev->irq = retval;
aux_bus->aux_device_wrapper[1]->gp_aux_data.irq_num = pdev->irq;
retval = auxiliary_device_init(&aux_bus->aux_device_wrapper[1]->aux_dev);
--
2.34.1
Powered by blists - more mailing lists