lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Sep 2022 08:12:04 -0700 From: Minchan Kim <minchan@...nel.org> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-mm <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, Matthew Wilcox <willy@...radead.org>, Yu Zhao <yuzhao@...gle.com>, Minchan Kim <minchan@...nel.org>, 韩天硕 <hantianshuo@....ac.cn>, Yang Shi <shy828301@...il.com>, stable@...r.kernel.org Subject: [PATCH] mm: fix madivse_pageout mishandling on non-LRU page MADV_PAGEOUT tries to isolate non-LRU pages and get the warning from isolate_lru_page below. Fix it with checking PageLRU in advance. ------------[ cut here ]------------ trying to isolate tail page WARNING: CPU: 0 PID: 6175 at mm/folio-compat.c:158 isolate_lru_page+0x130/0x140 Modules linked in: CPU: 0 PID: 6175 Comm: syz-executor.0 Not tainted 5.18.12 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 RIP: 0010:isolate_lru_page+0x130/0x140 Link: https://lore.kernel.org/linux-mm/485f8c33.2471b.182d5726afb.Coremail.hantianshuo@iie.ac.cn/ Reported-by: 韩天硕 <hantianshuo@....ac.cn> Suggested-by: Yang Shi <shy828301@...il.com> Fixes: 1a4e58cce84e ("mm: introduce MADV_PAGEOUT") Cc: stable@...r.kernel.org Signed-off-by: Minchan Kim <minchan@...nel.org> Acked-by: Yang Shi <shy828301@...il.com> --- mm/madvise.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 682e1d161aef..a3fc4cd32ed3 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -452,8 +452,11 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, continue; } - /* Do not interfere with other mappings of this page */ - if (page_mapcount(page) != 1) + /* + * Do not interfere with other mappings of this page and + * non-LRU page. + */ + if (!PageLRU(page) || page_mapcount(page) != 1) continue; VM_BUG_ON_PAGE(PageTransCompound(page), page); -- 2.37.2.672.g94769d06f0-goog
Powered by blists - more mailing lists