linux-kernel - Re: [PATCH] ethernet/sfc: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30f2488d-9af3-fe8d-6e6f-713a7d38800b@gmail.com>
Date:   Thu, 8 Sep 2022 17:07:47 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     wangjianli <wangjianli@...rlc.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet/sfc: fix repeated words in comments

On 08/09/2022 13:46, wangjianli wrote:
> Delete the redundant word 'in'.
> 
> Signed-off-by: wangjianli <wangjianli@...rlc.com>
> ---
>  drivers/net/ethernet/sfc/bitfield.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/bitfield.h b/drivers/net/ethernet/sfc/bitfield.h
> index 1f981dfe4bdc..0b502d1c3c9e 100644
> --- a/drivers/net/ethernet/sfc/bitfield.h
> +++ b/drivers/net/ethernet/sfc/bitfield.h
> @@ -117,7 +117,7 @@ typedef union efx_oword {
>   *
>   *   ( element ) << 4
>   *
> - * The result will contain the relevant bits filled in in the range
> + * The result will contain the relevant bits filled in the range
>   * [0,high-low), with garbage in bits [high-low+1,...).
>   */
>  #define EFX_EXTRACT_NATIVE(native_element, min, max, low, high)		\
> 

Nack.
"filled in" is a phrasal verb, so the existing text is correct.  Stet.

#ifdef RANT
NGL, getting kinda sick of these bogus comment text 'fixes' from people
 who clearly don't have enough mastery of English to copyedit it.
(Previous one from this author was actually wrong too but I didn't catch
 it at the time.)
English is a tricksy language, why would someone with a limited
 understanding of it think that grammar fixes are the best use of their
 time and energy?
I can't help suspecting that this is a box-ticking exercise, where a
 certain corporate culture has a standard requirement that engineers
 must get X number of Linux / opensource commits in order to get
 promoted, and this kind of mindless patch is the easiest way for them
 to achieve that.
#endif

-ed