| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Sep 2022 00:43:07 +0800
From: kernel test robot <lkp@...el.com>
To: Vlad Buslov <vladbu@...dia.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Pirko <jiri@...dia.com>, Sasha Levin <sashal@...nel.org>
Subject: [linux-stable-rc:linux-5.4.y 3300/5264]
net/sched/cls_flower.c:296:12: warning: stack frame size (1040) exceeds
limit (1024) in 'fl_classify'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
head: d6deb370b5a5389256f160f711c58561e0868ddf
commit: 5f2e54391893c67b709a64b280417ca0318adb73 [3300/5264] net/sched: flower: fix parsing of ethertype following VLAN header
config: mips-randconfig-r034-20220907
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=5f2e54391893c67b709a64b280417ca0318adb73
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-5.4.y
git checkout 5f2e54391893c67b709a64b280417ca0318adb73
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash net/sched/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> net/sched/cls_flower.c:296:12: warning: stack frame size (1040) exceeds limit (1024) in 'fl_classify' [-Wframe-larger-than]
static int fl_classify(struct sk_buff *skb, const struct tcf_proto *tp,
^
1 warning generated.
vim +/fl_classify +296 net/sched/cls_flower.c
e0ace68af2acfe Paul Blakey 2019-07-09 295
77b9900ef53ae0 Jiri Pirko 2015-05-12 @296 static int fl_classify(struct sk_buff *skb, const struct tcf_proto *tp,
77b9900ef53ae0 Jiri Pirko 2015-05-12 297 struct tcf_result *res)
77b9900ef53ae0 Jiri Pirko 2015-05-12 298 {
77b9900ef53ae0 Jiri Pirko 2015-05-12 299 struct cls_fl_head *head = rcu_dereference_bh(tp->root);
77b9900ef53ae0 Jiri Pirko 2015-05-12 300 struct fl_flow_key skb_mkey;
e0ace68af2acfe Paul Blakey 2019-07-09 301 struct fl_flow_key skb_key;
e0ace68af2acfe Paul Blakey 2019-07-09 302 struct fl_flow_mask *mask;
e0ace68af2acfe Paul Blakey 2019-07-09 303 struct cls_fl_filter *f;
77b9900ef53ae0 Jiri Pirko 2015-05-12 304
05cd271fd61a0b Paul Blakey 2018-04-30 305 list_for_each_entry_rcu(mask, &head->masks, list) {
50acd32ea7f682 Jason Baron 2020-02-17 306 flow_dissector_init_keys(&skb_key.control, &skb_key.basic);
05cd271fd61a0b Paul Blakey 2018-04-30 307 fl_clear_masked_range(&skb_key, mask);
bc3103f1ed405d Amir Vadai 2016-09-08 308
8212ed777f40c7 Jiri Pirko 2019-06-19 309 skb_flow_dissect_meta(skb, &mask->dissector, &skb_key);
05cd271fd61a0b Paul Blakey 2018-04-30 310 /* skb_flow_dissect() does not set n_proto in case an unknown
05cd271fd61a0b Paul Blakey 2018-04-30 311 * protocol, so do it rather here.
77b9900ef53ae0 Jiri Pirko 2015-05-12 312 */
9b7fd81cf9b6ca Toke Høiland-Jørgensen 2020-07-03 313 skb_key.basic.n_proto = skb_protocol(skb, false);
05cd271fd61a0b Paul Blakey 2018-04-30 314 skb_flow_dissect_tunnel_info(skb, &mask->dissector, &skb_key);
e0ace68af2acfe Paul Blakey 2019-07-09 315 skb_flow_dissect_ct(skb, &mask->dissector, &skb_key,
e0ace68af2acfe Paul Blakey 2019-07-09 316 fl_ct_info_to_flower_map,
e0ace68af2acfe Paul Blakey 2019-07-09 317 ARRAY_SIZE(fl_ct_info_to_flower_map));
05cd271fd61a0b Paul Blakey 2018-04-30 318 skb_flow_dissect(skb, &mask->dissector, &skb_key, 0);
77b9900ef53ae0 Jiri Pirko 2015-05-12 319
05cd271fd61a0b Paul Blakey 2018-04-30 320 fl_set_masked_key(&skb_mkey, &skb_key, mask);
77b9900ef53ae0 Jiri Pirko 2015-05-12 321
5c72299fba9df4 Amritha Nambiar 2018-11-12 322 f = fl_lookup(mask, &skb_mkey, &skb_key);
e8eb36cd8ca93f Amir Vadai 2016-06-13 323 if (f && !tc_skip_sw(f->flags)) {
77b9900ef53ae0 Jiri Pirko 2015-05-12 324 *res = f->res;
77b9900ef53ae0 Jiri Pirko 2015-05-12 325 return tcf_exts_exec(skb, &f->exts, res);
77b9900ef53ae0 Jiri Pirko 2015-05-12 326 }
05cd271fd61a0b Paul Blakey 2018-04-30 327 }
77b9900ef53ae0 Jiri Pirko 2015-05-12 328 return -1;
77b9900ef53ae0 Jiri Pirko 2015-05-12 329 }
77b9900ef53ae0 Jiri Pirko 2015-05-12 330
:::::: The code at line 296 was first introduced by commit
:::::: 77b9900ef53ae047e36a37d13a2aa33bb2d60641 tc: introduce Flower classifier
:::::: TO: Jiri Pirko <jiri@...nulli.us>
:::::: CC: David S. Miller <davem@...emloft.net>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (149602 bytes)
Powered by blists - more mailing lists