linux-kernel - Re: [PATCH v3 1/1] tracing: Fix compile error in trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28bd97af-2932-f75e-ecf5-6c5e42f8d7ad@acm.org>
Date:   Thu, 8 Sep 2022 09:55:48 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Arun Easi <aeasi@...vell.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Martin Petersen <martin.petersen@...cle.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        James Bottomley <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-next@...r.kernel.org, GR-QLogic-Storage-Upstream@...vell.com
Subject: Re: [PATCH v3 1/1] tracing: Fix compile error in trace_array calls
 when TRACING is disabled

On 9/7/22 16:33, Arun Easi wrote:
> diff --git a/include/linux/trace.h b/include/linux/trace.h
> index bf16961..b5e16e4 100644
> --- a/include/linux/trace.h
> +++ b/include/linux/trace.h
> @@ -2,8 +2,6 @@
>   #ifndef _LINUX_TRACE_H
>   #define _LINUX_TRACE_H
>   
> -#ifdef CONFIG_TRACING
> -
>   #define TRACE_EXPORT_FUNCTION	BIT(0)
>   #define TRACE_EXPORT_EVENT	BIT(1)
>   #define TRACE_EXPORT_MARKER	BIT(2)
> @@ -28,6 +26,8 @@ struct trace_export {
>   	int flags;
>   };
>   
> +#ifdef CONFIG_TRACING
> +
>   int register_ftrace_export(struct trace_export *export);
>   int unregister_ftrace_export(struct trace_export *export);
>   
> @@ -48,6 +48,38 @@ void osnoise_arch_unregister(void);
>   void osnoise_trace_irq_entry(int id);
>   void osnoise_trace_irq_exit(int id, const char *desc);
>   
> +#else /* CONFIG_TRACING */
> +static inline int register_ftrace_export(struct trace_export *export)
> +{
> +	return -EINVAL;
> +}
> +static inline int unregister_ftrace_export(struct trace_export *export)
> +{
> +	return 0;
> +}
> +static inline void trace_printk_init_buffers(void)
> +{
> +}
> +static inline int trace_array_printk(struct trace_array *tr, unsigned long ip,
> +				     const char *fmt, ...)
> +{
> +	return 0;
> +}
> +static inline int trace_array_init_printk(struct trace_array *tr)
> +{
> +	return -EINVAL;
> +}
> +static inline void trace_array_put(struct trace_array *tr)
> +{
> +}
> +static inline struct trace_array *trace_array_get_by_name(const char *name)
> +{
> +	return NULL;
> +}
> +static inline int trace_array_destroy(struct trace_array *tr)
> +{
> +	return 0;
> +}
>   #endif	/* CONFIG_TRACING */
>   
>   #endif	/* _LINUX_TRACE_H */

Thanks for having addressed my feedback. The above looks good to me. 
However, I'm not very familiar with the tracing framework so I will 
leave it to others to formally review this patch.

Thanks,

Bart.