linux-kernel - Re: [PATCH] um/kernel: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 19:45:58 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     wangjianli <wangjianli@...rlc.com>,
        Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        linux-um <linux-um@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] um/kernel: fix repeated words in comments

On Thu, Sep 8, 2022 at 2:56 PM Johannes Berg <johannes@...solutions.net> wrote:
> On Thu, 2022-09-08 at 20:54 +0800, wangjianli wrote:
> > Delete the redundant word 'in'.
> >
> > Signed-off-by: wangjianli <wangjianli@...rlc.com>
> > ---
> >  arch/um/kernel/physmem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/um/kernel/physmem.c b/arch/um/kernel/physmem.c
> > index e7c7b53a1435..91485119ae67 100644
> > --- a/arch/um/kernel/physmem.c
> > +++ b/arch/um/kernel/physmem.c
> > @@ -169,7 +169,7 @@ __uml_setup("iomem=", parse_iomem,
> >  );
> >
> >  /*
> > - * This list is constructed in parse_iomem and addresses filled in in
> > + * This list is constructed in parse_iomem and addresses filled in
> >   * setup_iomem, both of which run during early boot.  Afterwards, it's
> >
> Fine, I guess, but honestly - that sentence doesn't parse well either

Not fine, the repeated "in" is correct.
Q: "Where are addresses filled in?"
A: "In setup_iomem".

> way. Might be worth addressing that at the same time...

addresses are filled in?

General note: please stop submitting these patches for auto-detected
repeated words.  There are too many false positives.
Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds