linux-kernel - Re: [PATCH v2 2/3] hwmon: (tps23861) reduce count of i2c transactions for port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220908184930.GA3173818@roeck-us.net>
Date:   Thu, 8 Sep 2022 11:49:30 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Alexandru Gagniuc <mr.nuke.me@...il.com>
Cc:     linux-hwmon@...r.kernel.org, robert.marko@...tura.hr,
        luka.perkov@...tura.hr, jdelvare@...e.com, dev@...ehler.at,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] hwmon: (tps23861) reduce count of i2c
 transactions for port_status

On Tue, Sep 06, 2022 at 08:54:04PM -0500, Alexandru Gagniuc wrote:
> When reading the 'port_status' debugfs entry, some I2C registers were
> read more than once. This looks inefficient in an I2C trace.
> 
> To reduce I2C traffic, update tps23861_port_status_show() to only read
> each register once. Indexing the port number from 0 instead of 1 also
> allows simplifying things a bit.
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@...il.com>

Applied to hwmon-next.

Thanks,
Guenter