linux-kernel - [PATCH] ipc: mqueue: remove unnecessary conditionals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  9 Sep 2022 02:54:52 +0800
From:   Jingyu Wang <jingyuwang_vip@....com>
To:     akpm@...ux-foundation.org, ebiederm@...ssion.com,
        roman.gushchin@...ux.dev, hbh25y@...il.com, legion@...nel.org,
        longman@...hat.com, songmuchun@...edance.com
Cc:     linux-kernel@...r.kernel.org, Jingyu Wang <jingyuwang_vip@....com>
Subject: [PATCH] ipc: mqueue: remove unnecessary conditionals

iput() has already handled null and non-null parameter, so it is no
need to use if().

Signed-off-by: Jingyu Wang <jingyuwang_vip@....com>
---
 ipc/mqueue.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 9cf314b3f079..467a194b8a2e 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -986,8 +986,7 @@ SYSCALL_DEFINE1(mq_unlink, const char __user *, u_name)
 
 out_unlock:
 	inode_unlock(d_inode(mnt->mnt_root));
-	if (inode)
-		iput(inode);
+	iput(inode);
 	mnt_drop_write(mnt);
 out_name:
 	putname(name);

base-commit: 5957ac6635a1a12d4aa2661bbf04d3085a73372a
-- 
2.34.1