linux-kernel - Re: [PATCH V2 0/6] perf intel-pt: Support itrace option flag d+e to log on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yxo903EQ74Xl94DR@kernel.org>
Date:   Thu, 8 Sep 2022 16:09:07 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Jiri Olsa <jolsa@...hat.com>, Ian Rogers <irogers@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 0/6] perf intel-pt: Support itrace option flag d+e to
 log on error

Em Tue, Sep 06, 2022 at 10:24:03AM -0700, Namhyung Kim escreveu:
> HI Arnaldo,
> 
> On Tue, Sep 6, 2022 at 6:05 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> >
> > Em Mon, Sep 05, 2022 at 10:34:18AM +0300, Adrian Hunter escreveu:
> > > Hi
> > >
> > > Here are a few patches to add the ability to output the decoding debug log
> > > only when there are decoding errors.
> > >
> > > This is motivated by the fact that a full log can be very large, so just
> > > getting interesting bits is useful for analyzing errors.
> > >
> > > If necessary, the size of output on error is configurable via perf config,
> > > and perf_config_scan() was added in the 1st patch to make that simpler.
> > >
> > > The 2nd patch adds the new option flag to auxtrace.
> > >
> > > There are a couple of very minor and essentially unrelated changes in
> > > patches 3 and 4.
> > >
> > > The main Intel PT change is in patch 5 and there is a small example in the
> > > commit message.
> > >
> > >
> > > Changes in V2:
> > >
> > >       perf intel-pt: Support itrace option flag d+e to log on error
> > >       Ensure log_buf is defined before use
> > >
> > >       perf intel-pt: Remove first line of log dumped on error
> > >       Remove first line only if the buffer has wrapped
> >
> > Applied locally, Namhyung: I think your review comment was addressed,
> > right? If so can I add your Reviewed-by to all the patches in this
> > series?
> 
> Sure,
> 
> Reviewed-by: Namhyung Kim <namhyung@...nel.org>

Thanks, added.

- Arnaldo