linux-kernel - Re: [PATCH] staging: r8188eu: remove some unused enums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 21:15:43 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Michael Straube <straube.linux@...il.com>,
        gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove some unused enums

On 9/8/22 09:28, Michael Straube wrote:
> Remove some unused enums to clean up the driver code.
> 
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>   drivers/staging/r8188eu/include/rtl8188e_xmit.h |  6 ------
>   drivers/staging/r8188eu/include/rtw_mlme.h      | 11 -----------
>   drivers/staging/r8188eu/include/wlan_bssdef.h   |  4 ----
>   3 files changed, 21 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> index c69fed23ded9..6db7fabebea9 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> @@ -83,12 +83,6 @@
>   /* OFFSET 20 */
>   #define	RTY_LMT_EN		BIT(17)
>   
> -enum TXDESC_SC {
> -	SC_DONT_CARE = 0x00,
> -	SC_UPPER = 0x01,
> -	SC_LOWER = 0x02,
> -	SC_DUPLICATE = 0x03
> -};
>   /* OFFSET 20 */
>   #define SGI			BIT(6)
>   #define USB_TXAGG_NUM_SHT	24
> diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r8188eu/include/rtw_mlme.h
> index 5dc2fe74b7b7..a959e2100c3f 100644
> --- a/drivers/staging/r8188eu/include/rtw_mlme.h
> +++ b/drivers/staging/r8188eu/include/rtw_mlme.h
> @@ -63,17 +63,6 @@ enum rt_scan_type {
>   	SCAN_MIX,
>   };
>   
> -enum SCAN_RESULT_TYPE {
> -	SCAN_RESULT_P2P_ONLY = 0,	/* Will return all the P2P devices. */
> -	SCAN_RESULT_ALL = 1,		/* Will return all the scanned device,
> -					 * include AP. */
> -	SCAN_RESULT_WFD_TYPE = 2	/* Will just return the correct WFD
> -					 * device. */
> -					/* If this device is Miracast sink
> -					 * device, it will just return all the
> -					 * Miracast source devices. */
> -};
> -
>   /*
>   there are several "locks" in mlme_priv,
>   since mlme_priv is a shared resource between many threads,
> diff --git a/drivers/staging/r8188eu/include/wlan_bssdef.h b/drivers/staging/r8188eu/include/wlan_bssdef.h
> index 9d1c9e763287..81bda91a4136 100644
> --- a/drivers/staging/r8188eu/include/wlan_bssdef.h
> +++ b/drivers/staging/r8188eu/include/wlan_bssdef.h
> @@ -133,10 +133,6 @@ struct ndis_802_11_assoc_info {
>   	u32  OffsetResponseIEs;
>   };
>   
> -enum ndis_802_11_reload_def {
> -	Ndis802_11ReloadWEPKeys
> -};
> -
>   /*  Key mapping keys require a BSSID */
>   struct ndis_802_11_key {
>   	u32           Length;             /*  Length of this structure */

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> # Edimax N150