linux-kernel - Re: [PATCH] net: ipv4: Fix some coding style in ah4.c file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxpPvoejMMNliCrg@lunn.ch>
Date:   Thu, 8 Sep 2022 22:25:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jingyu Wang <jingyuwang_vip@....com>
Cc:     steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ipv4: Fix some coding style in ah4.c file

> @@ -165,7 +165,8 @@ static int ah_output(struct xfrm_state *x, struct sk_buff *skb)
>  	ahp = x->data;
>  	ahash = ahp->ahash;
>  
> -	if ((err = skb_cow_data(skb, 0, &trailer)) < 0)
> +	err = skb_cow_data(skb, 0, &trailer));

I prefer the coding style issue over it not compiling at all.

I suggest you don't embarrass yourself any more by compile testing
your changes.

     Andrew