linux-kernel - Re: [PATCH RESEND v6 1/4] drivers: hwmon: Add max31760 fan speed controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202209090420.yiz6T9uI-lkp@intel.com>
Date:   Fri, 9 Sep 2022 05:08:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ibrahim Tilki <Ibrahim.Tilki@...log.com>, jdelvare@...e.com,
        linux@...ck-us.net
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nurettin Bolucu <Nurettin.Bolucu@...log.com>
Subject: Re: [PATCH RESEND v6 1/4] drivers: hwmon: Add max31760 fan speed
 controller driver

Hi Ibrahim,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on linus/master v6.0-rc4 next-20220908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ibrahim-Tilki/hwmon-Add-max31760-fan-speed-controller/20220908-162723
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20220909/202209090420.yiz6T9uI-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a7a9956fb85372f1d08a355df3af7d64c927a987
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ibrahim-Tilki/hwmon-Add-max31760-fan-speed-controller/20220908-162723
        git checkout a7a9956fb85372f1d08a355df3af7d64c927a987
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/hwmon/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/hwmon/max31760.c:382:5: warning: no previous prototype for function 'max31760_read_string' [-Wmissing-prototypes]
   int max31760_read_string(struct device *dev, enum hwmon_sensor_types type,
       ^
   drivers/hwmon/max31760.c:382:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int max31760_read_string(struct device *dev, enum hwmon_sensor_types type,
   ^
   static 
   1 warning generated.


vim +/max31760_read_string +382 drivers/hwmon/max31760.c

   381	
 > 382	int max31760_read_string(struct device *dev, enum hwmon_sensor_types type,
   383				 u32 attr, int channel, const char **str)
   384	{
   385		switch (type) {
   386		case hwmon_temp:
   387			if (attr != hwmon_temp_label)
   388				return -EOPNOTSUPP;
   389	
   390			*str = channel ? "local" : "remote";
   391	
   392			return 0;
   393		default:
   394			return -EOPNOTSUPP;
   395		}
   396	}
   397	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp