lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Sep 2022 00:16:55 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: matthew.gerlach@...ux.intel.com Cc: hao.wu@...el.com, yilun.xu@...el.com, russell.h.weight@...el.com, basheer.ahmed.muddebihal@...el.com, trix@...hat.com, mdf@...nel.org, linux-fpga@...r.kernel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, tianfei.zhang@...el.com, corbet@....net, gregkh@...uxfoundation.org, linux-serial@...r.kernel.org, jirislaby@...nel.org, geert+renesas@...der.be, niklas.soderlund+renesas@...natech.se, phil.edworthy@...esas.com, macro@...am.me.uk, johan@...nel.org, lukas@...ner.de Subject: Re: [PATCH v1 5/5] tty: serial: 8250: add DFL bus driver for Altera 16550. On Thu, Sep 08, 2022 at 11:27:03AM -0700, matthew.gerlach@...ux.intel.com wrote: > On Tue, 6 Sep 2022, Andy Shevchenko wrote: > > On Tue, Sep 06, 2022 at 12:04:26PM -0700, matthew.gerlach@...ux.intel.com wrote: ... > > > + dev_dbg(dfluart->dev, "UART_CLK_ID %llu Hz\n", dfluart->uart_clk); > > > > Isn't this available via normal interfaces to user? > > I am not sure what "normal interfaces to user" you are referring to. The > code is just trying to read the frequency of the input clock to the uart > from a DFH paramter. I mean dev_dbg() call. The user can get uart_clk via one of the UART/serial ABIs (don't remember which one, though). ... > > > +#define FME_FEATURE_ID_UART 0x24 > > > > Purpose of this definition? For me with or without is still an ID. > > I don't think I understand the question. Is the name of the macro unclear, > or do you think it is not necessary? I mean how the definition is useful / useless. I.o.w. I think it's not necessary. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists