linux-kernel - Re: [RFC PATCH v3 2/4] ufs: core: mcq: Adds Multi-Circular Queue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877d782d-8fb1-44bc-6de9-1c3c7f8667f3@acm.org>
Date:   Thu, 8 Sep 2022 15:02:47 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Bean Huo <huobean@...il.com>,
        Asutosh Das <quic_asutoshd@...cinc.com>,
        quic_nguyenb@...cinc.com, quic_xiaosenh@...cinc.com,
        stanley.chu@...iatek.com, adrian.hunter@...el.com,
        avri.altman@....com, mani@...nel.org, quic_cang@...cinc.com,
        beanhuo@...ron.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org
Cc:     linux-arm-msm@...r.kernel.org,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Jinyoung Choi <j-young.choi@...sung.com>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v3 2/4] ufs: core: mcq: Adds Multi-Circular Queue
 support

On 9/5/22 09:27, Bean Huo wrote:
> static read_queues is not initialized.

Hi Bean,

The Linux kernel coding style guide does not allow to explicitly 
initialize static variables to zero. The C standard requires that static 
variables that are not initialized explicitly are initialized to zero. 
 From https://en.wikipedia.org/wiki/.bss: "In C, statically allocated 
objects without an explicit initializer are initialized to zero (for 
arithmetic types) or a null pointer (for pointer types)."

Thanks,

Bart.