linux-kernel - Re: [PATCH v3 16/22] KVM: kvm_arch.c: Remove a global variable, hardware_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 15:51:13 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     Yuan Yao <yuan.yao@...ux.intel.com>
Cc:     isaku.yamahata@...el.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>, Will Deacon <will@...nel.org>,
        isaku.yamahata@...il.com, Kai Huang <kai.huang@...el.com>,
        Chao Gao <chao.gao@...el.com>,
        Atish Patra <atishp@...shpatra.org>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>,
        Qi Liu <liuqi115@...wei.com>,
        John Garry <john.garry@...wei.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Huang Ying <ying.huang@...el.com>,
        Huacai Chen <chenhuacai@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v3 16/22] KVM: kvm_arch.c: Remove a global variable,
 hardware_enable_failed

On Wed, Sep 07, 2022 at 01:56:57PM +0800,
Yuan Yao <yuan.yao@...ux.intel.com> wrote:

> > +static void hardware_enable(void *arg)
> > +{
> > +	atomic_t *failed = arg;
> > +
> > +	if (__hardware_enable((void *)__func__))
> > +		atomic_inc(failed);
> >  }
> 
> A side effect: The actual caller_name information introduced in Patch
> 3 for hardware_enable() is lost. I tend to keep the information, but
> depends on you and other guys. :-)

That's true.  But only kvm_arch_add_vm() calls hardware_enable() and other call
sites are converted to call __hardware_enable().  There is no confusion with
other callers with this patch series.  So I decided not to bother to pass
function name in addition to a failed counter.

-- 
Isaku Yamahata <isaku.yamahata@...il.com>