linux-kernel - Re: [PATCH v5 2/4] Input: joystick: xpad: Add ABS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxl/YxSRtV9Hv271@google.com>
Date:   Wed, 7 Sep 2022 22:36:35 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     Nate Yocom <nate@...om.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, benjamin.tissoires@...hat.com
Subject: Re: [PATCH v5 2/4] Input: joystick: xpad: Add ABS_PROFILE axis value
 to uapi

On Wed, Sep 07, 2022 at 05:41:08PM +0200, Bastien Nocera wrote:
> On Mon, 2022-08-29 at 12:07 -0700, Nate Yocom wrote:
> > On Sat, Aug 27, 2022 at 12:40:46PM +0200, Bastien Nocera wrote:
> > > On Thu, 2022-08-25 at 15:24 -0700, Nate Yocom wrote:
> > > > Add an ABS_PROFILE axis for input devices which need it, e.g. X-
> > > > Box
> > > > Adaptive Controller and X-Box Elite 2.
> > > > ---
> > > >  include/uapi/linux/input-event-codes.h | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/include/uapi/linux/input-event-codes.h
> > > > b/include/uapi/linux/input-event-codes.h
> > > > index dff8e7f17074..7ad931a32970 100644
> > > > --- a/include/uapi/linux/input-event-codes.h
> > > > +++ b/include/uapi/linux/input-event-codes.h
> > > > @@ -862,6 +862,7 @@
> > > >  #define ABS_TOOL_WIDTH         0x1c
> > > >  
> > > >  #define ABS_VOLUME             0x20
> > > > +#define ABS_PROFILE            0x21
> > > >  
> > > >  #define ABS_MISC               0x28
> > > >  
> > > 
> > > 
> > > You probably also want to add it to the absolutes array in
> > > drivers/hid/hid-debug.c.
> > 
> > doh, roger.
> > 
> > > Again, you might want to wait for confirmation from Dmitry that
> > > this is
> > > the right way to do this for the profiles.
> > 
> > Makes sense.  Dmitry?
> 
> Dmitry, could you please confirm whether ABS_PROFILE definition is
> correct?

Yes, I think this makes sense. Do we have a buy in from userspace folks
(Peter H, etc) for this?

I'd like some documentation added to Documentation/input/event-codes.rst
and potentially to Documentation/input/gamepad.rst even though profile
does not have to be gamepad specific event.

Thanks.

-- 
Dmitry