linux-kernel - RE: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for ZynqMP OCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB4258C4746631BBD6A7B388D6DB409@BY5PR12MB4258.namprd12.prod.outlook.com>
Date:   Thu, 8 Sep 2022 05:39:56 +0000
From:   "Potthuri, Sai Krishna" <sai.krishna.potthuri@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "saikrishna12468@...il.com" <saikrishna12468@...il.com>,
        "git (AMD-Xilinx)" <git@....com>,
        "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
Subject: RE: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for ZynqMP OCM

Hi Boris,

> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Wednesday, September 7, 2022 7:31 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri@....com>
> Cc: Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Michal Simek
> <michal.simek@...inx.com>; Mauro Carvalho Chehab
> <mchehab@...nel.org>; Tony Luck <tony.luck@...el.com>; James Morse
> <james.morse@....com>; Robert Richter <rric@...nel.org>;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; linux-edac@...r.kernel.org;
> saikrishna12468@...il.com; git (AMD-Xilinx) <git@....com>; Datta,
> Shubhrajyoti <shubhrajyoti.datta@....com>
> Subject: Re: [PATCH v4 2/2] edac: zynqmp_ocm: Add EDAC support for
> ZynqMP OCM
> 
> On Wed, Sep 07, 2022 at 04:45:31PM +0530, Sai Krishna Potthuri wrote:
> > Add EDAC support for Xilinx ZynqMP OCM Controller, this driver reports
> > CE and UE errors based on the interrupts, and also creates ue/ce sysfs
> > entries for error injection.
> >
> > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@....com>
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
> 
> I think you folks need to brush up on
> 
> Documentation/process/submitting-patches.rst
> 
> in order to build your SOB chain properly.
Got it, i will add "Co-developed-by" tag and send v5.

> 
> > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index
> > 58ab63642e72..08adedfd42b5 100644
> > --- a/drivers/edac/Kconfig
> > +++ b/drivers/edac/Kconfig
> > @@ -539,4 +539,13 @@ config EDAC_DMC520
> >  	  Support for error detection and correction on the
> >  	  SoCs with ARM DMC-520 DRAM controller.
> >
> > +config EDAC_ZYNQMP_OCM
> > +	tristate "Xilinx ZynqMP OCM Controller"
> > +	depends on ARCH_ZYNQMP || COMPILE_TEST
> 
> We already have an EDAC driver which depends on ARCH_ZYNQMP - the
> Synopsys one. Can this one be made part of it?
Synopsys EDAC driver is targeted for DDR Memory Controller and this driver
is for OCM (On Chip Memory) Controller, both are different hardware controllers.

Regards
Sai Krishna