linux-kernel - RE: [PATCH -next v2 3/5] misc: microchip: pci1xxxx: Make symbol 'pci1xxxx_gpio_auxiliary_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 06:02:38 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <weiyongjun@...weicloud.com>, <arnd@...db.de>,
        <gregkh@...uxfoundation.org>
CC:     <weiyongjun1@...wei.com>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <lkp@...el.com>
Subject: RE: [PATCH -next v2 3/5] misc: microchip: pci1xxxx: Make symbol
 'pci1xxxx_gpio_auxiliary_id_table' static

> -----Original Message-----
> From: Wei Yongjun <weiyongjun@...weicloud.com>
> Sent: Wednesday, September 7, 2022 8:28 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>; Arnd Bergmann
> <arnd@...db.de>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; linux-gpio@...r.kernel.org;
> linux-kernel@...r.kernel.org; kernel test robot <lkp@...el.com>
> Subject: [PATCH -next v2 3/5] misc: microchip: pci1xxxx: Make symbol
> 'pci1xxxx_gpio_auxiliary_id_table' static
> 
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> The sparse tool complains as follows:
> 
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:409:34: warning:
>  symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be
> static?
> 
> This symbol is not used outside of mchp_pci1xxxx_gpio.c, so marks it static.
> 
> Fixes: 7d3e4d807df2 ("misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver.")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>

> ---
> v1 -> v2: add fixes tag and reported-by
> ---
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> index 47e6e87938ae..4f26871994ee 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> @@ -407,7 +407,7 @@ static int pci1xxxx_gpio_probe(struct auxiliary_device
> *aux_dev,
> 
>  static SIMPLE_DEV_PM_OPS(pci1xxxx_gpio_pm_ops,
> pci1xxxx_gpio_suspend, pci1xxxx_gpio_resume);
> 
> -const struct auxiliary_device_id pci1xxxx_gpio_auxiliary_id_table[] = {
> +static const struct auxiliary_device_id pci1xxxx_gpio_auxiliary_id_table[] = {
>         {.name = "mchp_pci1xxxx_gp.gp_gpio"},
>         {}
>  };
> --
> 2.34.1