linux-kernel - RE: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use module_auxiliary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN8PR11MB366875590A4F506A398B3FCDE9409@BN8PR11MB3668.namprd11.prod.outlook.com>
Date:   Thu, 8 Sep 2022 06:16:24 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <weiyongjun@...weicloud.com>, <arnd@...db.de>,
        <gregkh@...uxfoundation.org>
CC:     <weiyongjun1@...wei.com>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use
 module_auxiliary_driver

> -----Original Message-----
> From: Wei Yongjun <weiyongjun@...weicloud.com>
> Sent: Wednesday, September 7, 2022 8:28 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>; Arnd Bergmann
> <arnd@...db.de>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; linux-gpio@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: [PATCH -next v2 5/5] misc: microchip: pci1xxxx: use
> module_auxiliary_driver
> 
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Use the module_auxiliary_driver() macro to make the code simpler by
> eliminating module_init and module_exit calls.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
Fixes: 7d3e4d807df2 ("misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver.")

Reviewed-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>

> ---
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> index fa80a7788596..9cc771c604ed 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> @@ -421,19 +421,7 @@ static struct auxiliary_driver pci1xxxx_gpio_driver = {
>         .probe = pci1xxxx_gpio_probe,
>         .id_table = pci1xxxx_gpio_auxiliary_id_table  };
> -
> -static int __init pci1xxxx_gpio_driver_init(void) -{
> -       return auxiliary_driver_register(&pci1xxxx_gpio_driver);
> -}
> -
> -static void __exit pci1xxxx_gpio_driver_exit(void) -{
> -       auxiliary_driver_unregister(&pci1xxxx_gpio_driver);
> -}
> -
> -module_init(pci1xxxx_gpio_driver_init);
> -module_exit(pci1xxxx_gpio_driver_exit);
> +module_auxiliary_driver(pci1xxxx_gpio_driver);
> 
>  MODULE_DESCRIPTION("Microchip Technology Inc. PCI1xxxx GPIO
> controller");  MODULE_AUTHOR("Kumaravel Thiagarajan
> <kumaravel.thiagarajan@...rochip.com>");
> --
> 2.34.1