linux-kernel - Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 08 Sep 2022 08:23:18 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     Takashi Iwai <tiwai@...e.de>, Lu Baolu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <jroedel@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Robin Murphy <robin.murphy@....com>,
        Eric Auger <eric.auger@...hat.com>,
        regressions@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19

On Wed, 07 Sep 2022 15:48:33 +0200,
Jason Gunthorpe wrote:
> 
> On Wed, Sep 07, 2022 at 03:28:31PM +0200, Takashi Iwai wrote:
> > >  /**
> > >   * iommu_device_use_default_domain() - Device driver wants to handle device
> > >   *                                     DMA through the kernel DMA API.
> > > @@ -3094,8 +3112,7 @@ int iommu_device_use_default_domain(struct device *dev)
> > >  
> > >  	mutex_lock(&group->mutex);
> > >  	if (group->owner_cnt) {
> > > -		if (group->domain != group->default_domain ||
> > > -		    group->owner) {
> > > +		if (group->owner || iommu_is_default_domain(group)) {
> > 
> > Isn't this rather 
> > 		if (group->owner || !iommu_is_default_domain(group)) {
> > ?
> > 
> > I'll rebuild the kernel with this change and ask reporters again.
> 
> Oh yes, good eyes, that probably crashes on boot too

Indeed the corrected patch seems working; it boots and the HD-audio
device appears again.

Can we go forward with this?


thanks,

Takashi