[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Yxmb7wTBRnRuasxI@google.com>
Date: Thu, 8 Sep 2022 08:38:23 +0100
From: Lee Jones <lee@...nel.org>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: Martin Kaiser <martin@...ser.cx>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Lucas Stach <l.stach@...gutronix.de>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mfd: fsl-imx25: fix check for platform_get_irq() errors
On Thu, 11 Aug 2022, Dan Carpenter wrote:
> The mx25_tsadc_remove() function assumes all non-zero returns are success
> but the platform_get_irq() function returns negative on error and
> positive non-zero values on success. It never returns zero, but if it
> did then treat that as a success.
>
> Fixes: 18f773937968 ("mfd: fsl-imx25: Clean up irq settings during removal")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> drivers/mfd/fsl-imx25-tsadc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists