linux-kernel - Re: test ./tools/testing/selftests/bpf/test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR11MB1320BB40A48D230A1A196318C5409@CY4PR11MB1320.namprd11.prod.outlook.com>
Date:   Thu, 8 Sep 2022 07:44:06 +0000
From:   "Zhou, Jie2X" <jie2x.zhou@...el.com>
To:     Ido Schimmel <idosch@...sch.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "mykolal@...com" <mykolal@...com>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "martin.lau@...ux.dev" <martin.lau@...ux.dev>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Li, Philip" <philip.li@...el.com>,
        "petrm@...dia.com" <petrm@...dia.com>
Subject: Re: test ./tools/testing/selftests/bpf/test_offload.py failed

hi ido,

>> My error is  "Exception: Command failed: cat /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex"
>This one is solved by the netdevsim patch ([2]).
Thanks for your reply.
About netdevsim patch ([2]), do you commit it to kernel mail list?

best regards,

________________________________________
From: Ido Schimmel <idosch@...sch.org>
Sent: Thursday, September 8, 2022 2:23 PM
To: Zhou, Jie2X
Cc: kuba@...nel.org; andrii@...nel.org; mykolal@...com; ast@...nel.org; daniel@...earbox.net; martin.lau@...ux.dev; davem@...emloft.net; hawk@...nel.org; netdev@...r.kernel.org; bpf@...r.kernel.org; linux-kselftest@...r.kernel.org; linux-kernel@...r.kernel.org; Li, Philip; petrm@...dia.com
Subject: Re: test ./tools/testing/selftests/bpf/test_offload.py failed

On Thu, Sep 08, 2022 at 03:10:51AM +0000, Zhou, Jie2X wrote:
> My error is  "Exception: Command failed: cat /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex"

This one is solved by the netdevsim patch ([2]).

> Do you get [1]error, after patch [2]?

Yes. Maybe you do not see it because you have an older bpftool without
"libbpf_strict" feature:

$ bpftool --version
bpftool v6.8.0
using libbpf v0.8
features: libbfd, libbpf_strict, skeletons

> [1]
> # bpftool prog load /home/idosch/code/linux/tools/testing/selftests/bpf/sample_ret0.o /sys/fs/bpf/nooffload type xdp
> Error: object file doesn't contain any bpf program
> Warning: bpftool is now running in libbpf strict mode and has more stringent requirements about BPF programs.
> If it used to work for this object file but now doesn't, see --legacy option for more details.
>
> [2]
> diff --git a/drivers/net/netdevsim/hwstats.c b/drivers/net/netdevsim/hwstats.c
> index 605a38e16db0..0e58aa7f0374 100644
> --- a/drivers/net/netdevsim/hwstats.c
> +++ b/drivers/net/netdevsim/hwstats.c
> @@ -433,11 +433,11 @@ int nsim_dev_hwstats_init(struct nsim_dev *nsim_dev)
>                 goto err_remove_hwstats_recursive;
>         }
>
> -       debugfs_create_file("enable_ifindex", 0600, hwstats->l3_ddir, hwstats,
> +       debugfs_create_file("enable_ifindex", 0200, hwstats->l3_ddir, hwstats,
>                             &nsim_dev_hwstats_l3_enable_fops.fops);
> -       debugfs_create_file("disable_ifindex", 0600, hwstats->l3_ddir, hwstats,
> +       debugfs_create_file("disable_ifindex", 0200, hwstats->l3_ddir, hwstats,
>                             &nsim_dev_hwstats_l3_disable_fops.fops);
> -       debugfs_create_file("fail_next_enable", 0600, hwstats->l3_ddir, hwstats,
> +       debugfs_create_file("fail_next_enable", 0200, hwstats->l3_ddir, hwstats,
>                             &nsim_dev_hwstats_l3_fail_fops.fops);
>
>         INIT_DELAYED_WORK(&hwstats->traffic_dw,