linux-kernel - Re: [PATCH V3] firmware: google: Test spinlock on panic path to avoid lockups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <887931a4-c1df-8b4b-6594-864b96e50217@igalia.com>
Date:   Wed, 7 Sep 2022 21:35:49 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     Evan Green <evgreen@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     Petr Mladek <pmladek@...e.com>, Arnd Bergmann <arnd@...db.de>,
        linux-efi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        kernel@...ccoli.net, Ard Biesheuvel <ardb@...nel.org>,
        David Gow <davidgow@...gle.com>,
        Julius Werner <jwerner@...omium.org>
Subject: Re: [PATCH V3] firmware: google: Test spinlock on panic path to avoid
 lockups

On 06/09/2022 14:09, Evan Green wrote:
> [...]
> 
> I basically came to the same conclusion as Andrew. It seems like this
> patch does fix a problem, which is a panic coming in on another CPU
> and NMIing on top of a CPU doing a normal operation holding this lock.
> The problem seems pretty theoretical, but I suppose I don't have
> numbers one way or another since any attempt to gather numbers would
> be reliant on this very mechanism. My Reviewed-by tag is already on
> there.
> -Evan

Thanks for the feedback Evan and Andrew.

So if Greg (or anybody else) doesn't oppose, I'll send a V4 with the
commit message/comment suggestions.

Cheers,


Guilherme