linux-kernel - Re: [PATCH] mfd: fix tests for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yxml9asIAhYkY240@google.com>
Date:   Thu, 8 Sep 2022 09:21:09 +0100
From:   Lee Jones <lee@...nel.org>
To:     Yu Zhe <yuzhe@...china.com>
Cc:     shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        liqiong@...china.com
Subject: Re: [PATCH] mfd: fix tests for platform_get_irq() failure

On Thu, 25 Aug 2022, Yu Zhe wrote:

> The platform_get_irq() returns negative error codes.  It can't actually
> return zero.
> 
> Signed-off-by: Yu Zhe <yuzhe@...china.com>
> ---
>  drivers/mfd/fsl-imx25-tsadc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Already fixed: https://lore.kernel.org/r/YvTfkbVQWYKMKS/t@kili

> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index 37e5e02a1d05..8ccdfd73e694 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -179,7 +179,7 @@ static int mx25_tsadc_remove(struct platform_device *pdev)
>  	struct mx25_tsadc *tsadc = platform_get_drvdata(pdev);
>  	int irq = platform_get_irq(pdev, 0);
>  
> -	if (irq) {
> +	if (irq > 0) {
>  		irq_set_chained_handler_and_data(irq, NULL, NULL);
>  		irq_domain_remove(tsadc->domain);
>  	}

-- 
Lee Jones [李琼斯]