linux-kernel - Re: [PATCH v10 0/2] Introduce block device LED trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 10:37:48 +0200 (CEST)
From:   torvic9@...lbox.org
To:     Ian Pilcher <arequipeno@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>
Subject: Re: [PATCH v10 0/2] Introduce block device LED trigger


> Ian Pilcher <arequipeno@...il.com> hat am 07.09.2022 15:11 GMT geschrieben:
> 
>  
> On 9/7/22 07:16, torvic9@...lbox.org wrote:
> > Hi Ian,
> > 
> > with a heavily patched Linux 6.0-rc4 with kfence, kmemleak and slub_debug I get the
> > following splat at boot:
> 
> Sorry about that!  I'm not sure how that slipped throgh, as I was sure
> that I tested the new version before I sent it off.
> 
> Basically, I messed up while cleaning up the function parameter names,
> so you need to apply this:
> 
> --- drivers/leds/trigger/ledtrig-blkdev.c.old   2022-09-07 
> 10:00:26.194484681 -0500
> +++ drivers/leds/trigger/ledtrig-blkdev.c       2022-09-04 
> 11:36:16.107690614 -0500
> @@ -540,7 +540,7 @@
>                  return ERR_PTR(-ENOMEM);
> 
>          bdev = blkdev_get_by_path(strim(buf), BLKDEV_TRIG_FMODE, 
> THIS_MODULE);
> -       kfree(path);
> +       kfree(buf);
>          return bdev;
>   }
> 

This fixes the issue, no more errors.
Thank you!

> > I'm not 100% sure if this is an issue with ledtrig_blkdev or something else,
> > but I thought I'll let you know about it.
> > I have not been able to test this on a vanilla kernel yet.
> 
> Defnintely my fault.
> 
> > Other than that, I hope this patchset gets included in upstream.
> > I have been using it for a long time now and found it very useful.
> 
> It's really hard to know if anyone is interested in/using this, so
> that's great to hear.

When and if you send a v11, you can add my
  Tested-by: Tor Vic <torvic9@...lbox.org>

> 
> -- 
> ========================================================================
> Google                                      Where SkyNet meets Idiocracy
> ========================================================================