linux-kernel - Re: [PATCH v9 10/16] mei: mkhi: add memory ready command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2022 17:51:28 -0700
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@...el.com>
To:     Tomas Winkler <tomas.winkler@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
CC:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
        <intel-gfx@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        "Alexander Usyskin" <alexander.usyskin@...el.com>,
        Vitaly Lubart <vitaly.lubart@...el.com>
Subject: Re: [PATCH v9 10/16] mei: mkhi: add memory ready command



On 9/7/2022 2:51 PM, Tomas Winkler wrote:
> Add GSC memory ready command.
> The command indicates to the firmware that extend operation
> memory was setup and the firmware may enter PXP mode.
>
> CC: Daniele Ceraolo Spurio <daniele.ceraolospurio@...el.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@...el.com>

Daniele

> ---
> V9: Fix duplicated defines caused by wrong --amend
>
>   drivers/misc/mei/mkhi.h | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/drivers/misc/mei/mkhi.h b/drivers/misc/mei/mkhi.h
> index c3fa3c5d5cb6..1473ea489666 100644
> --- a/drivers/misc/mei/mkhi.h
> +++ b/drivers/misc/mei/mkhi.h
> @@ -16,6 +16,13 @@
>   #define MKHI_GEN_GROUP_ID 0xFF
>   #define MKHI_GEN_GET_FW_VERSION_CMD 0x2
>   
> +#define MKHI_GROUP_ID_GFX              0x30
> +#define MKHI_GFX_RESET_WARN_CMD_REQ    0x0
> +#define MKHI_GFX_MEMORY_READY_CMD_REQ  0x1
> +
> +/* Allow transition to PXP mode without approval */
> +#define MKHI_GFX_MEM_READY_PXP_ALLOWED  0x1
> +
>   struct mkhi_rule_id {
>   	__le16 rule_type;
>   	u8 feature_id;
> @@ -40,4 +47,9 @@ struct mkhi_msg {
>   	u8 data[];
>   } __packed;
>   
> +struct mkhi_gfx_mem_ready {
> +	struct mkhi_msg_hdr hdr;
> +	u32    flags;
> +} __packed;
> +
>   #endif /* _MEI_MKHI_H_ */