linux-kernel - Re: [PATCH v2] mfd: stmpe: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxnGWRIrabWTKwxk@google.com>
Date:   Thu, 8 Sep 2022 11:39:21 +0100
From:   Lee Jones <lee@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] mfd: stmpe: switch to using gpiod API

On Tue, 06 Sep 2022, Dmitry Torokhov wrote:

> This patch switches the driver away from legacy gpio/of_gpio API to
> gpiod API, and removes use of of_get_named_gpio_flags() which I want to
> make private to gpiolib.
> 
> We also need to patch relevant DTS files, as the original code relied on
> the fact that of_get_named_gpio_flags() would fetch any data encoded in
> GPIO flags, even if it does not reflect valid flags for a GPIO.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
> 
> v1->v2:
>  - add DTS changes, as noticed by Francesco Dolcini.
> 
> I guess we could do a dance of changing stmpe to check the flags coming
> from DTS and try to distinguish IRQ flags from proper GPIO flags, then
> have a separate patch changing DTSes, and finally a 2nd patch to stmpe
> to use GPIOD API, but I am hoping we could apply this in one go...
> 
>  arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi |  2 +-
>  arch/arm/boot/dts/tegra30-apalis.dtsi      |  2 +-
>  arch/arm/boot/dts/tegra30-colibri.dtsi     |  2 +-
>  drivers/mfd/stmpe.c                        | 36 ++++++++--------------
>  4 files changed, 16 insertions(+), 26 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]