linux-kernel - RE: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DBBPR08MB4538E77A2E291EB869A5A26CF7409@DBBPR08MB4538.eurprd08.prod.outlook.com>
Date:   Thu, 8 Sep 2022 01:11:52 +0000
From:   Justin He <Justin.He@....com>
To:     "Kani, Toshi" <toshi.kani@....com>, Len Brown <lenb@...nel.org>,
        James Morse <James.Morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        Robert Moore <robert.moore@...el.com>,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>,
        Yazen Ghannam <yazen.ghannam@....com>,
        Jan Luebbe <jlu@...gutronix.de>,
        Khuong Dinh <khuong@...amperecomputing.com>
CC:     Ard Biesheuvel <ardb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        nd <nd@....com>
Subject: RE: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to
 remove the dependency on ghes

Hi Kani

> -----Original Message-----
> From: Kani, Toshi <toshi.kani@....com>
> Sent: Thursday, September 8, 2022 8:31 AM
> To: Justin He <Justin.He@....com>; Len Brown <lenb@...nel.org>; James
> Morse <James.Morse@....com>; Tony Luck <tony.luck@...el.com>; Borislav
> Petkov <bp@...en8.de>; Mauro Carvalho Chehab <mchehab@...nel.org>;
> Robert Richter <rric@...nel.org>; Robert Moore <robert.moore@...el.com>;
> Qiuxu Zhuo <qiuxu.zhuo@...el.com>; Yazen Ghannam
> <yazen.ghannam@....com>; Jan Luebbe <jlu@...gutronix.de>; Khuong
> Dinh <khuong@...amperecomputing.com>
> Cc: Ard Biesheuvel <ardb@...nel.org>; linux-acpi@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org; devel@...ica.org;
> Rafael J . Wysocki <rafael@...nel.org>; Shuai Xue
> <xueshuai@...ux.alibaba.com>; Jarkko Sakkinen <jarkko@...nel.org>;
> linux-efi@...r.kernel.org; nd <nd@....com>
> Subject: RE: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to
> remove the dependency on ghes
> 
> On Monday, September 5, 2022 9:25 AM, Jia He wrote:
> > -void ghes_edac_unregister(struct ghes *ghes)
> > +static void ghes_edac_unregister(struct ghes *ghes)
> >  {
> >  	struct mem_ctl_info *mci;
> >  	unsigned long flags;
> >
> > -	if (!ghes_edac_force_enable)
> > -		return;
> > -
> 
> I am not familiar with this original check.  Assuming it is safe to delete it now
> (as you mentioned in other email w/o description), I suggest adding some
> description to the commit log.
> 
Thanks, will do
I've tested the insmod/rmmod multiple times on Arm host.

I will wait for others' comments for a while before sending the new version.
> At high-level, the patch looks good to me.
> Acked-by: Toshi Kani <toshi.kani@....com>

Thanks a lot for the help 😊

--
Cheers,
Justin (Jia He)