linux-kernel - Re: [PATCH v3] pinctrl: qcom: spmi-gpio: Make irqchip immutable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 14:25:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        bjorn.andersson@...aro.org, robimarko@...il.com,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, maz@...nel.org,
        johan+linaro@...nel.org, steev@...i.org
Subject: Re: [PATCH v3] pinctrl: qcom: spmi-gpio: Make irqchip immutable

On Tue, Aug 30, 2022 at 2:08 PM Johan Hovold <johan@...nel.org> wrote:

> > +     irq_chip_unmask_parent(data);
> > +     gpiochip_enable_irq(gc, data->hwirq);
>
> Could you set the IRQ-enabled flag before unmasking the parent here for
> symmetry (and as most other implementations do)?

I fixed this up while applying so no need to resend.

Patch applied!

Yours,
Linus Walleij