linux-kernel - Re: [PATCH] sched/fair: Fix misuse of available_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 21:49:21 +0800
From:   Abel Wu <wuyun.abel@...edance.com>
To:     Peter Zijlstra <peterz@...radead.org>, Mel Gorman <mgorman@...e.de>
Cc:     Vincent Guittot <vincent.guittot@...aro.org>,
        Rohit Jain <rohit.k.jain@...cle.com>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/fair: Fix misuse of available_idle_cpu()

On 9/8/22 9:17 PM, Peter Zijlstra wrote:
> On Thu, Sep 08, 2022 at 11:36:32AM +0100, Mel Gorman wrote:
>> On Thu, Sep 08, 2022 at 04:07:02PM +0800, Abel Wu wrote:
>>> The function available_idle_cpu() was introduced to distinguish
>>> between the code paths that cares if the vCPU is preempted and
>>> the ones don't care. In general, available_idle_cpu() is used in
>>> selecting cpus for immediate use, e.g. ttwu. While idle_cpu() is
>>> used in the paths that only cares about the cpu is idle or not,
>>> and __update_idle_core() is one of them.
>>>
>>> Use idle_cpu() instead in the idle path to make has_idle_core
>>> a better hint.
>>>
>>> Fixes: 943d355d7fee (sched/core: Distinguish between idle_cpu() calls based on desired effect, introduce available_idle_cpu())
>>> Signed-off-by: Abel Wu <wuyun.abel@...edance.com>
>>
>> Seems fair. As vCPU preemption is specific to virtualisation, it is very
>> unlikely that SMT is exposed to the guest so the impact of the patch is
> 
> Right; only pinned guests typically expose such topology information
> (anything else would be quite broken).
> 
>> minimal but I still think it's right so;
> 
> I'm not convinced; all of select_idle_sibling() seems to use
> available_idle_cpu(), and that's the only consumer of
> __update_idle_core(), so in that respect the current state makes sense.

Hi Peter, Mel, thanks for your reviewing!

My thought was that the preempted core can become active again before
select_idle_sibling() is called, so using available_idle_cpu() in
__update_idle_core() can potentially lose the opportunity to kick an
idle core running. While the downside of using idle_cpu() is that a
full scan can be triggered irrespective of non-preempted cores exist,
but even available_idle_cpu() can not make sure of that either.

BTW, I am also confused with select_idle_core() in which all the cpus
of a core need to be non-preempted before the core can be taken as an
idle core. IMHO, it might be enough that at least one cpu of an idle
core is non-preempted and allowed by task's taskset.

Thanks & BR,
Abel