linux-kernel - Re: [PATCH] riscv: kprobes: Free instruction in arch_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <819b4964-0f81-74d4-1dd5-e836326447ec@huawei.com>
Date:   Thu, 8 Sep 2022 09:54:29 +0800
From:   "liaochang (A)" <liaochang1@...wei.com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
CC:     <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: kprobes: Free instruction in arch_remove_kprobe()

Hi, Tiezhu,

This bug is fixed already, see https://lore.kernel.org/all/cd9a856b-ed8a-88f1-da69-4fb628c28f34@huawei.com/T/

在 2022/9/8 9:39, Tiezhu Yang 写道:
> Call free_insn_slot() to free instruction in arch_remove_kprobe()
> as other arches do.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  arch/riscv/kernel/probes/kprobes.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/kernel/probes/kprobes.c b/arch/riscv/kernel/probes/kprobes.c
> index e6e950b..f12eb1f 100644
> --- a/arch/riscv/kernel/probes/kprobes.c
> +++ b/arch/riscv/kernel/probes/kprobes.c
> @@ -110,6 +110,10 @@ void __kprobes arch_disarm_kprobe(struct kprobe *p)
>  
>  void __kprobes arch_remove_kprobe(struct kprobe *p)
>  {
> +	if (p->ainsn.api.insn) {
> +		free_insn_slot(p->ainsn.api.insn, 0);
> +		p->ainsn.api.insn = NULL;
> +	}
>  }
>  
>  static void __kprobes save_previous_kprobe(struct kprobe_ctlblk *kcb)

-- 
BR,
Liao, Chang