linux-kernel - RE: [PATCH] soc/tegra: pmc: Print reset info during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 14:16:00 +0000
From:   Petlozu Pravareshwar <petlozup@...dia.com>
To:     Thierry Reding <thierry.reding@...il.com>
CC:     Jonathan Hunter <jonathanh@...dia.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "dmitry.osipenko@...labora.com" <dmitry.osipenko@...labora.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "Kartik ." <kkartik@...dia.com>,
        "cai.huoqing@...ux.dev" <cai.huoqing@...ux.dev>,
        Sandipan Patra <spatra@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] soc/tegra: pmc: Print reset info during probe

> On Wed, Aug 24, 2022 at 07:39:46PM +0000, Petlozu Pravareshwar wrote:
> > >
> > > On Wed, Aug 17, 2022 at 06:44:56PM +0000, Petlozu Pravareshwar wrote:
> > > > During PMC probe, print previous reset related info such as reset
> > > > reason and reset level.
> > > >
> > > > Signed-off-by: Petlozu Pravareshwar <petlozup@...dia.com>
> > > > ---
> > > >  drivers/soc/tegra/pmc.c | 27 +++++++++++++++++++++++++++
> > > >  1 file changed, 27 insertions(+)
> > >
> > > We already expose this information in sysfs, why do we need to print
> > > it during boot?
> > >
> > > Thierry
> > There are some tests which would parse the boot log for this information.
> > But I agree, since we are already providing this information through
> > sysfs, there is no need to print it during boot.
> 
> It'd be a good idea to transition the tests to try and obtain this information
> through sysfs first and if that fails they could fall back to using the boot log.
> Although to be honest, I think we've supported this sysfs interface for long
> enough that we probably don't have to worry about a fallback.
> 
> Thierry
Agree. Transitioning the tests to obtain the information through sysfs looks
good to me. I think this change can be discarded as printing the info in the
boot log is no longer needed.

Thanks.