linux-kernel - Re: [igt-dev] [PATCH i-g-t v2 2/4] lib/igt_kmod.c: check if module is builtin before attempting to unload it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13576898.RDIVbhacDa@jkrzyszt-mobl1.ger.corp.intel.com>
Date:   Fri, 09 Sep 2022 17:10:52 +0200
From:   Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
To:     igt-dev@...ts.freedesktop.org
Cc:     linux-kselftest@...r.kernel.org, daniel@...ll.ch,
        kunit-dev@...glegroups.com, magalilemes00@...il.com,
        maira.canal@....br, dlatypov@...gle.com, n@...aprado.net,
        linux-kernel@...r.kernel.org, leandro.ribeiro@...labora.com,
        dri-devel@...ts.freedesktop.org, davidgow@...gle.com,
        tales.aparecida@...il.com, skhan@...uxfoundation.org,
        andrealmeid@...eup.net, Isabella Basso <isabbasso@...eup.net>,
        brendanhiggins@...gle.com, twoerner@...il.com,
        Isabella Basso <isabbasso@...eup.net>
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/4] lib/igt_kmod.c: check if module is builtin before attempting to unload it

On Monday, 29 August 2022 02:09:18 CEST Isabella Basso wrote:
> This change makes `igt_module_unload_r` safer as it checks whether the

s/igt_module_unload_r/igt_kmod_unload_r/

> module can be unloaded before attempting it.
> 
> Signed-off-by: Isabella Basso <isabbasso@...eup.net>
> ---
>  lib/igt_kmod.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index bb6cb7bb..97cac7f5 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -256,6 +256,9 @@ static int igt_kmod_unload_r(struct kmod_module *kmod, unsigned int flags)
>  	struct kmod_list *holders, *pos;
>  	int err = 0;
>  
> +	if (kmod_module_get_initstate(kmod) == KMOD_MODULE_BUILTIN)
> +		return err;

NIT: I think that return 0; would be more clear.  Anyway,

Acked-by: Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>

> +
>  	holders = kmod_module_get_holders(kmod);
>  	kmod_list_foreach(pos, holders) {
>  		struct kmod_module *it = kmod_module_get_module(pos);
>