linux-kernel - RE: [PATCH v2 15/15] vfio: Add struct device to vfio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 03:09:48 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Jason Gunthorpe <jgg@...pe.ca>, Eric Auger <eric.auger@...hat.com>
CC:     Matthew Rosato <mjrosato@...ux.ibm.com>,
        David Airlie <airlied@...ux.ie>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Eric Farman <farman@...ux.ibm.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kirti Wankhede <kwankhede@...dia.com>,
        Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Diana Craciun <diana.craciun@....nxp.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Longfang Liu <liulongfang@...wei.com>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        "Liu, Yi L" <yi.l.liu@...el.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        Leon Romanovsky <leon@...nel.org>,
        Halil Pasic <pasic@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "Wang, Zhi A" <zhi.a.wang@...el.com>,
        "Tony Krowiak" <akrowiak@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        "Heiko Carstens" <hca@...ux.ibm.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        "Alex Williamson" <alex.williamson@...hat.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        "intel-gvt-dev@...ts.freedesktop.org" 
        <intel-gvt-dev@...ts.freedesktop.org>,
        Jason Herne <jjherne@...ux.ibm.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
        Yishai Hadas <yishaih@...dia.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Abhishek Sahu <abhsahu@...dia.com>
Subject: RE: [PATCH v2 15/15] vfio: Add struct device to vfio_device

> From: Jason Gunthorpe
> Sent: Thursday, September 8, 2022 8:37 PM
> 
> On Thu, Sep 08, 2022 at 11:39:07AM +0200, Eric Auger wrote:
> 
> > >> I am not totally clear about remaining 'struct device *dev;' in
> > >> vfio_device struct. I see it used in some places. Is it supposed to
> > >> disappear at some point?
> > >
> > > no, Eric. *dev will not disappear, it stores the dev pointet passed in by
> > > caller of vfio_init_device().
> >
> > yeah I see but you have device->device.parent = device->dev;
> 
> IIRC we have a number of these redundancies now, often the drivers
> store another copy of the dev too.
> 
> A significant use of dev is for printing things, what should be done
> here is to create a subsystem wide vfio_warn/etc that takes in the
> vfio_device, and then print properly from there. Now that we have a
> struct device all the prints should also include the VFIO struct
> device name, and then the PCI device perhaps in brackets.
> 

Let me handle it in a separate patch (after this series).