linux-kernel - Re: [PATCH v2] sched/topology: Add __init for init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 13:26:14 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Bing Huang <huangbing775@....com>
Cc:     dietmar.eggemann@....com, brauner@...nel.org, bristot@...hat.com,
        bsegall@...gle.com, juri.lelli@...hat.com,
        linux-kernel@...r.kernel.org, mgorman@...e.de, mingo@...hat.com,
        peterz@...radead.org, vincent.guittot@...aro.org
Subject: Re: [PATCH v2] sched/topology: Add __init for init_defrootdomain

On Fri,  9 Sep 2022 14:24:06 +0800
Bing Huang <huangbing775@....com> wrote:

> From: Bing Huang <huangbing@...inos.cn>
> 
> init_defrootdomain is only used in initialization
> 
> Signed-off-by: Bing Huang <huangbing@...inos.cn>
> Reviewed-by: Steven Rostedt <rostedt@...dmis.org>

Do not add a reviewed-by tag unless it is explicitly stated that you can.
Just because someone reviews your patch does not mean it allows you to add
that tag. I have not reviewed this version of the patch, and the last
version was not acceptable.

That said, this version is acceptable. But that still doesn't mean it was
right to add that tag before I gave the OK. That's because that tag carries
some weight of responsibility to those that give their review.

Now-Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
> Reviewed-by: Valentin Schneider <vschneid@...hat.com>
> ---
>  v1->v2:
>    Remove __init in function prototype
> 
>  kernel/sched/topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 8739c2a5a54e..dea9fa39e7c0 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -578,7 +578,7 @@ static int init_rootdomain(struct root_domain *rd)
>   */
>  struct root_domain def_root_domain;
>  
> -void init_defrootdomain(void)
> +void __init init_defrootdomain(void)
>  {
>  	init_rootdomain(&def_root_domain);
>