[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 10 Sep 2022 04:10:44 +0800
From: kernel test robot <lkp@...el.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Shawn Guo <shawn.guo@...aro.org>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Pali Rohár <pali@...nel.org>,
Bjorn Helgaas <helgaas@...nel.org>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
Rob Herring <robh@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] PCI: mvebu: switch to using gpiod API
Hi Dmitry,
I love your patch! Yet something to improve:
[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on linus/master v6.0-rc4 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Torokhov/PCI-histb-switch-to-using-gpiod-API/20220907-044417
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm-multi_v5_defconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/90d5c7ec598d196395d3a5934099b56d1c8e071a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dmitry-Torokhov/PCI-histb-switch-to-using-gpiod-API/20220907-044417
git checkout 90d5c7ec598d196395d3a5934099b56d1c8e071a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> drivers/pci/controller/pci-mvebu.c:1100:2: error: call to undeclared function 'chained_irq_enter'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
chained_irq_enter(chip, desc);
^
>> drivers/pci/controller/pci-mvebu.c:1115:2: error: call to undeclared function 'chained_irq_exit'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
chained_irq_exit(chip, desc);
^
2 errors generated.
vim +/chained_irq_enter +1100 drivers/pci/controller/pci-mvebu.c
ec075262648f39 Pali Rohár 2022-02-22 1091
ec075262648f39 Pali Rohár 2022-02-22 1092 static void mvebu_pcie_irq_handler(struct irq_desc *desc)
ec075262648f39 Pali Rohár 2022-02-22 1093 {
ec075262648f39 Pali Rohár 2022-02-22 1094 struct mvebu_pcie_port *port = irq_desc_get_handler_data(desc);
ec075262648f39 Pali Rohár 2022-02-22 1095 struct irq_chip *chip = irq_desc_get_chip(desc);
ec075262648f39 Pali Rohár 2022-02-22 1096 struct device *dev = &port->pcie->pdev->dev;
ec075262648f39 Pali Rohár 2022-02-22 1097 u32 cause, unmask, status;
ec075262648f39 Pali Rohár 2022-02-22 1098 int i;
ec075262648f39 Pali Rohár 2022-02-22 1099
ec075262648f39 Pali Rohár 2022-02-22 @1100 chained_irq_enter(chip, desc);
ec075262648f39 Pali Rohár 2022-02-22 1101
ec075262648f39 Pali Rohár 2022-02-22 1102 cause = mvebu_readl(port, PCIE_INT_CAUSE_OFF);
ec075262648f39 Pali Rohár 2022-02-22 1103 unmask = mvebu_readl(port, PCIE_INT_UNMASK_OFF);
ec075262648f39 Pali Rohár 2022-02-22 1104 status = cause & unmask;
ec075262648f39 Pali Rohár 2022-02-22 1105
ec075262648f39 Pali Rohár 2022-02-22 1106 /* Process legacy INTx interrupts */
ec075262648f39 Pali Rohár 2022-02-22 1107 for (i = 0; i < PCI_NUM_INTX; i++) {
ec075262648f39 Pali Rohár 2022-02-22 1108 if (!(status & PCIE_INT_INTX(i)))
ec075262648f39 Pali Rohár 2022-02-22 1109 continue;
ec075262648f39 Pali Rohár 2022-02-22 1110
ec075262648f39 Pali Rohár 2022-02-22 1111 if (generic_handle_domain_irq(port->intx_irq_domain, i) == -EINVAL)
ec075262648f39 Pali Rohár 2022-02-22 1112 dev_err_ratelimited(dev, "unexpected INT%c IRQ\n", (char)i+'A');
ec075262648f39 Pali Rohár 2022-02-22 1113 }
ec075262648f39 Pali Rohár 2022-02-22 1114
ec075262648f39 Pali Rohár 2022-02-22 @1115 chained_irq_exit(chip, desc);
ec075262648f39 Pali Rohár 2022-02-22 1116 }
ec075262648f39 Pali Rohár 2022-02-22 1117
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (172454 bytes)
Powered by blists - more mailing lists