linux-kernel - Re: [PATCH -next] drm/amd/display: remove possible condition with no effect (if == else)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 16:43:49 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     alexander.deucher@....com, sunpeng.li@....com,
        Abaci Robot <abaci@...ux.alibaba.com>, Xinhui.Pan@....com,
        Rodrigo.Siqueira@....com, linux-kernel@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, christian.koenig@....com
Subject: Re: [PATCH -next] drm/amd/display: remove possible condition with no
 effect (if == else)

Applied.  Thanks!

Alex

On Thu, Sep 1, 2022 at 4:34 AM Yang Li <yang.lee@...ux.alibaba.com> wrote:
>
> Conditional statements have no effect to next process.So remove it.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2028
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c   | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index e4fd540dec0f..8f1c0e12dd86 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -4663,10 +4663,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>         } else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
>                 *MinPrefetchMode = 0;
>                 *MaxPrefetchMode = 0;
> -       } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
> -                       dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
> -               *MinPrefetchMode = 0;
> -               *MaxPrefetchMode = 3;
>         } else {
>                 *MinPrefetchMode = 0;
>                 *MaxPrefetchMode = 3;
> --
> 2.20.1.7.g153144c
>