linux-kernel - Re: [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 16:45:15 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     cgel.zte@...il.com
Cc:     alexander.deucher@....com, airlied@...ux.ie,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>, Xinhui.Pan@....com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, christian.koenig@....com
Subject: Re: [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable

Applied.  Thanks!

On Fri, Sep 2, 2022 at 3:32 AM <cgel.zte@...il.com> wrote:
>
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Return the value ci_load_smc_ucode() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/gpu/drm/radeon/ci_dpm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
> index ac006bed4743..8ef25ab305ae 100644
> --- a/drivers/gpu/drm/radeon/ci_dpm.c
> +++ b/drivers/gpu/drm/radeon/ci_dpm.c
> @@ -2056,7 +2056,7 @@ static void ci_clear_vc(struct radeon_device *rdev)
>  static int ci_upload_firmware(struct radeon_device *rdev)
>  {
>         struct ci_power_info *pi = ci_get_pi(rdev);
> -       int i, ret;
> +       int i;
>
>         for (i = 0; i < rdev->usec_timeout; i++) {
>                 if (RREG32_SMC(RCU_UC_EVENTS) & BOOT_SEQ_DONE)
> @@ -2067,9 +2067,7 @@ static int ci_upload_firmware(struct radeon_device *rdev)
>         ci_stop_smc_clock(rdev);
>         ci_reset_smc(rdev);
>
> -       ret = ci_load_smc_ucode(rdev, pi->sram_end);
> -
> -       return ret;
> +       return ci_load_smc_ucode(rdev, pi->sram_end);
>
>  }
>
> --
> 2.25.1