linux-kernel - Re: [PATCH] writeback: remove unused macro DIRTY_FULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 11:36:34 +0200
From:   Jan Kara <jack@...e.cz>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     axboe@...nel.dk, dhowells@...hat.com, vbabka@...e.cz,
        willy@...radead.org, akpm@...ux-foundation.org,
        zhanglianjie@...ontech.com, neilb@...e.de, jack@...e.cz,
        bvanassche@....org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] writeback: remove unused macro DIRTY_FULL_SCOPE

On Fri 09-09-22 10:57:11, Miaohe Lin wrote:
> It's introduced but never used. Remove it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/linux/writeback.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index 3f045f6d6c4f..06f9291b6fd5 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -17,20 +17,12 @@ struct bio;
>  DECLARE_PER_CPU(int, dirty_throttle_leaks);
>  
>  /*
> - * The 1/4 region under the global dirty thresh is for smooth dirty throttling:
> - *
> - *	(thresh - thresh/DIRTY_FULL_SCOPE, thresh)
> - *
> - * Further beyond, all dirtier tasks will enter a loop waiting (possibly long
> - * time) for the dirty pages to drop, unless written enough pages.
> - *
>   * The global dirty threshold is normally equal to the global dirty limit,
>   * except when the system suddenly allocates a lot of anonymous memory and
>   * knocks down the global dirty threshold quickly, in which case the global
>   * dirty limit will follow down slowly to prevent livelocking all dirtier tasks.
>   */
>  #define DIRTY_SCOPE		8
> -#define DIRTY_FULL_SCOPE	(DIRTY_SCOPE / 2)
>  
>  struct backing_dev_info;
>  
> -- 
> 2.23.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR