linux-kernel - Re: [PATCH 2/2] perf tools: remove perf_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 11:29:43 +0100
From:   James Clark <james.clark@....com>
To:     Gaosheng Cui <cuigaosheng1@...wei.com>
Cc:     linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, namhyung@...nel.org, atrajeev@...ux.vnet.ibm.com,
        eranian@...gle.com
Subject: Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration



On 09/09/2022 05:45, Gaosheng Cui wrote:
> perf_pmu_lex has been removed since
> commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> so remove it.

Not 100% sure if that is the right commit to reference because it didn't
touch pmu.y.

perf_pmu_lex is still used and there are plenty of references to it, but
maybe the extern declaration isn't needed anymore because it still
builds for me with this change.

> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> ---
>  tools/perf/util/pmu.y | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
> index bfd7e8509869..0dab0ec2eff7 100644
> --- a/tools/perf/util/pmu.y
> +++ b/tools/perf/util/pmu.y
> @@ -10,8 +10,6 @@
>  #include <string.h>
>  #include "pmu.h"
>  
> -extern int perf_pmu_lex (void);
> -
>  #define ABORT_ON(val) \
>  do { \
>          if (val) \