linux-kernel - Re: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2022 11:19:53 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Arnd Bergmann <arnd@...db.de>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of
 creating a PPC dependency



Le 09/09/2022 à 13:09, Arnd Bergmann a écrit :
> On Fri, Sep 9, 2022, at 11:03 AM, Lukas Bulwahn wrote:
>> Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
>> PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
>> that all architectures simply select this config when the architecture
>> supports using the PATA_PLATFORM driver.
>>
>> This is properly implemented already for all architectures except for the
>> powerpc architecture. Implement this for powerpc now.
>>
>> Adjust the config of the powerpc architecture to use the config
>> HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
>> any specific architecture anymore.
>>
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
>> ---
>>   arch/powerpc/Kconfig | 1 +
>>   drivers/ata/Kconfig  | 2 +-
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 39d71d7701bd..2575e21b6e6b 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -237,6 +237,7 @@ config PPC
>>   	select HAVE_MOD_ARCH_SPECIFIC
>>   	select HAVE_NMI				if PERF_EVENTS || (PPC64 && PPC_BOOK3S)
>>   	select HAVE_OPTPROBES
>> +	select HAVE_PATA_PLATFORM
>>   	select HAVE_PERF_EVENTS
>>   	select HAVE_PERF_EVENTS_NMI		if PPC64
>>   	select HAVE_PERF_REGS
> 
> I don't see a single powerpc machine that creates a
>   name="pata_platform" platform_device. I suspect this was
> only needed bwfore 2007 commit 9cd55be4d223 ("[POWERPC] pasemi:
> Move electra-ide to pata_of_platform"), so the "|| PPC"
> bit should just get removed without adding the HAVE_PATA_PLATFORM
> bit.

But that was added in 2008 by commit 61f7162117d4 ("libata: 
pata_of_platform: OF-Platform PATA device driver")