linux-kernel - Re: [PATCH] PCI: apple: do not leak reset GPIO on unbind/unload/error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19af505c00efeb2166fdcfca1de0948b@kernel.org>
Date:   Fri, 09 Sep 2022 13:48:56 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: apple: do not leak reset GPIO on unbind/unload/error

On 2022-09-09 10:16, Lorenzo Pieralisi wrote:
> Nit: please capitalize beginning of the sentence in the subject - 
> that's
> what we do for PCI controllers commits.
> 
> "PCI: apple: Do not leak reset GPIO on unbind/unload/error"
> 
> On Mon, Sep 05, 2022 at 07:15:23PM -0700, Dmitry Torokhov wrote:
>> The driver allocates reset GPIO in apple_pcie_setup_port() but neither
>> releases the resource, nor uses devm API to have it released
>> automatically.
>> 
>> Let's fix this by switching to devm API. While at it let's use generic
>> devm_fwnode_gpiod_get() instead of OF-specific 
>> gpiod_get_from_of_node()
>> - this will allow us top stop exporting the latter down the road.
>> 
>> Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up")
> 
> Should I take it via the PCI tree ? Usually we send fixes through -rcX
> only if the fix applies to code merged last merge window, which is not
> the case here, so I would queue if for v6.1.

I think 6.1 is perfectly fine.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...