lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Sep 2022 15:03:01 +0200 From: Vincent Guittot <vincent.guittot@...aro.org> To: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com, dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com, linux-kernel@...r.kernel.org, parth@...ux.ibm.com Cc: qais.yousef@....com, chris.hyser@...cle.com, valentin.schneider@....com, patrick.bellasi@...bug.net, David.Laight@...lab.com, pjt@...gle.com, pavel@....cz, tj@...nel.org, qperret@...gle.com, tim.c.chen@...ux.intel.com, joshdon@...gle.com, Vincent Guittot <vincent.guittot@...aro.org> Subject: [PATCH v3 0/8] Add latency priority for CFS class This patchset restarts the work about adding a latency priority to describe the latency tolerance of cfs tasks. The patches [1-4] have been done by Parth: https://lore.kernel.org/lkml/20200228090755.22829-1-parth@linux.ibm.com/ I have just rebased and moved the set of latency priority outside the priority update. I have removed the reviewed tag because the patches are 2 years old. The patch [5] uses latency nice priority to define a latency offset and then to decide if a cfs task can preempt the current running task. The patch gives some tests results with cyclictests and hackbench to highlight the benefit of latency priority for short interactive task or long intensive tasks. Patch [6] adds the support of latency_offset to task group by adding a cpu.latency field. There were discussions for the last version about using a real unit for the field so I decided to expose directly the latency offset which reflects the time up to which we can preempt when the value is negative, or up to which we can defer the preemption when the value is positive. The range is [-sysctl_sched_latency:sysctl_sched_latency] Patch [7] makes sched_core taking into account the latency offset. Patch [8] adds a rb tree to cover some corner cases where the latency sensitive task is preempted by high priority task (RT/DL) or fails to preempt them. This patch ensures that tasks will have at least a slice of sched_min_granularity in priority at wakeup. The patch gives results to show the benefit in addition to patch 5 I have also backported the patchset on a dragonboard RB3 with an android mainline kernel based on v5.18 for a quick test. I have used the TouchLatency app which is part of AOSP and described to be very good test to highlight jitter and jank frame sources of a system [1]. In addition to the app, I have added some short running tasks waking-up regularly (to use the 8 cpus for 4 ms every 37777us) to stress the system without overloading it (and disabling EAS). The 1st results shows that the patchset helps to reduce the missed deadline frames from 5% to less than 0.1% when the cpu.latency of task group are set. [1] https://source.android.com/docs/core/debug/eval_perf#touchlatency Change since v2: - Set a latency_offset field instead of saving a weight and computing it on the fly. - Make latency_offset available for task group: cpu.latency - Fix some corner cases to make latency sensitive tasks schedule first and add a rb tree for latency sensitive task. Change since v1: - fix typo - move some codes in the right patch to make bisect happy - simplify and fixed how the weight is computed - added support of sched core patch 7 Parth Shah (4): sched: Introduce latency-nice as a per-task attribute sched/core: Propagate parent task's latency requirements to the child task sched: Allow sched_{get,set}attr to change latency_nice of the task sched/core: Add permission checks for setting the latency_nice value Vincent Guittot (4): sched/fair: Take into account latency priority at wakeup sched/fair: Add sched group latency support sched/core: support latency priority with sched core sched/fair: Add latency list include/linux/sched.h | 5 + include/uapi/linux/sched.h | 4 +- include/uapi/linux/sched/types.h | 19 ++++ init/init_task.c | 1 + kernel/sched/core.c | 81 +++++++++++++ kernel/sched/debug.c | 1 + kernel/sched/fair.c | 189 ++++++++++++++++++++++++++++++- kernel/sched/sched.h | 35 ++++++ tools/include/uapi/linux/sched.h | 4 +- 9 files changed, 332 insertions(+), 7 deletions(-) -- 2.17.1
Powered by blists - more mailing lists